Add indexing of dropdown entries using Block State #2186
Conversation
Fixes: google#1940 Uses the Block State as suggested here: google#2004 (comment)
Set is not a suitable data structure to store the block State as an object, as it is using the object reference to test for uniqueness. The State is now stringified in the Set, and the set will contain a string version of the State object
…e bug. Fixed bug that didn't indexed the last trigram from a word
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello! Before I give you an in-depth review, there's a few steps that should be taken:
I'll get back to you with more specific comments soon. Thanks! |
|
Heya @ictin Are you still interested in working on this? if not I'll close it the 23rd |
|
@BeksOmega I will close it, as I will need to use my corporate email in the commits and pull request to have the CLA. I will close this one and open a clean one |
The basics
The details
Resolves
Fixes #1940 using the proposed solution from #2004
Fixes
Proposed Changes
The search should find the block and select the dropdown item. Also, both option[0] and option[1] of the dropdown will be indexed.
Reason for Changes
The search fails to find blocks with a dropdown.
Test Coverage
The unit tests have been updated and extended to test for all possible 3-letter combinations as search terms. The new tests have revealed an existing bug, where the last trigram of a word was not indexed. This caused a search for 'ace' for example to fail for "replace". This is fixed in this pull request
Documentation
No update of the documentation is required. Although an remark could be made.
Additional Information