Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input field a little bit shifted in fullscreen mode #4382

Open
bartbutenaers opened this issue Oct 18, 2020 · 1 comment
Open

Input field a little bit shifted in fullscreen mode #4382

bartbutenaers opened this issue Oct 18, 2020 · 1 comment
Labels
component: fields issue: bug Describes why the code or behaviour is wrong

Comments

@bartbutenaers
Copy link

Dear,

Some months ago Sam and Rachel have been so kind to fix my fullscreen issue. This allows me to show my Blockly workspace in fullscreen, and still be able to enter data into the input fields.

That works fine now, but there is a minor esthetic issue.
When data is being entered into the input field, the input field is a bit shifted (when in fullscreen mode):

blockly_fullscreen

This is the element involved, which is on top of the input field:

image

So really not a big issue! But if somebody ever has an idea how to solve this, that would be nice.

To Reproduce

Same way of working as described as in the original issue.

Expected behavior

Show the html input exactly on top of the input field.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome, Edge Chromium, Firefox
  • Version: most recent version of these browsers

Kind regards,
Bart

@bartbutenaers bartbutenaers added issue: triage Issues awaiting triage by a Blockly team member issue: bug Describes why the code or behaviour is wrong labels Oct 18, 2020
@moniika moniika added this to the Bug Bash Backlog milestone Oct 20, 2020
@moniika moniika removed the issue: triage Issues awaiting triage by a Blockly team member label Oct 20, 2020
@alschmiedt alschmiedt self-assigned this Nov 30, 2020
@samelhusseini
Copy link
Contributor

I wasn't able to reproduce this, although I only tried on a Mac and I recognize the issue states it was run on Chrome on Windows.
Are you able to reproduce this on the Blockly playground?
If so, can you share more about your setup.

Here's how I tried to repro, using the Blockly playground:
Change the DOM from <div id="blocklyDiv"></div> to:

  <div id="blocklyArea">
    <div id="blocklyDiv"></div>
  </div>

Add this line at the beginning of the start method:

  Blockly.setParentContainer(document.getElementById('blocklyArea'));

Replace the #blocklyDiv css with:


  #blocklyArea {
    float: right;
    height: 95%;
    width: 70%;
  }
  #blocklyDiv {
    height: 100%;
    width: 100%;
  }

Load the Blockly playground, and then run from the console:
document.getElementById('blocklyArea').requestFullscreen();

Let me know if you're still able to repro with the above steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: fields issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

4 participants