-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for undefined in horizontal flyout layout function #7522
Labels
ghc-osd
Reserved for open source day: https://anitab-org.github.io/open-source-day/
issue: bug
Describes why the code or behaviour is wrong
Comments
rachel-fenichel
added
issue: bug
Describes why the code or behaviour is wrong
issue: triage
Issues awaiting triage by a Blockly team member
labels
Sep 22, 2023
1 task
BeksOmega
added
ghc-osd
Reserved for open source day: https://anitab-org.github.io/open-source-day/
and removed
rrf-internal
labels
Sep 22, 2023
I'd love to work on this |
I want to work on this |
Thanks for your interest! This is being worked on in the |
Does that mean any of us can do the issue? |
Please join the breakout room to see what the status is and who is working on this. |
Hi, we are currently in the breakout room and would like to be assigned this code as we made progress. Thanks! |
priya-rjb
added a commit
to priya-rjb/blockly
that referenced
this issue
Sep 22, 2023
…o, & Yuchi Hsieh
1 task
priya-rjb
added a commit
to priya-rjb/blockly
that referenced
this issue
Sep 22, 2023
priya-rjb
added a commit
to priya-rjb/blockly
that referenced
this issue
Sep 22, 2023
johnnesky
pushed a commit
that referenced
this issue
Sep 24, 2023
…7522 (#7537) * #7522 edits -- collaborated with Hinal Patel, Swedhaa Sri Elango, & Yuchi Hsieh * #7522 edits: collaborated with Hinal Patel, Swedhaa Sri Elango, & Yuchi Hsieh * fix: non-nullable check for block variable and removed ! in layout_ #7522 * fix: non-nullable check for block variable and removed ! in layout_
cpcallen
removed
the
issue: triage
Issues awaiting triage by a Blockly team member
label
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ghc-osd
Reserved for open source day: https://anitab-org.github.io/open-source-day/
issue: bug
Describes why the code or behaviour is wrong
Check for duplicates
Description
In
layout_
inflyout_horizontal.ts
we access the block withconst block = item.block
. The result is nullable, so all later uses ofblock
have to have a non-null assertionTo fix:
block
isundefined
after settingconst block = item.block
.continue
ifblock
doesn't exist.!
from after the remaining uses ofblock
within the for loop.To get set up for this issue:
npm install
from the root of the repository.npm run build
from the root of the repository.npm run start
to launch the test playground.The text was updated successfully, but these errors were encountered: