Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to drag multi-block assemblies from toolbox in javafx #7556

Open
1 task done
KlemenDEV opened this issue Sep 29, 2023 · 1 comment
Open
1 task done
Labels
issue: bug Describes why the code or behaviour is wrong low priority

Comments

@KlemenDEV
Copy link

KlemenDEV commented Sep 29, 2023

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

Following up #7444, now rendering works fine without glitches. However, now when a block with sub-blocks is dragged from the toolbox, an error is thrown and Blockly becomes unusable.

Does not happen on eg. Chrome, just JavaFX.

Reproduction steps

Reproducible example: demo.zip

Used the same way as in #7444, except now try dragging block assembly from toolbox and see error shown in terminal. Does not happen if a single block is in the toolbox (eg. just print, not print with text block attached).

image

Stack trace

The crash happens because svgGroup is null at

svgGroup.setAttribute('display', 'none');

There could be more to it, this is just what I have managed to debug with limited JavaFX webview debug capabilites

@KlemenDEV KlemenDEV added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Sep 29, 2023
@maribethb maribethb changed the title Not possible to drag multi-block assemblies from toolbox Not possible to drag multi-block assemblies from toolbox in javafx Oct 11, 2023
@rachel-fenichel
Copy link
Collaborator

If you can track this down to a bug that we can fix by adding another IS_JAVA_FX flag we will consider it, but we don't have the resources to put a ton of time into debugging what looks like implementation issues in JavaFX itself.

@rachel-fenichel rachel-fenichel added low priority and removed issue: triage Issues awaiting triage by a Blockly team member labels Oct 18, 2023
@tashee tashee assigned tashee and unassigned tashee Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong low priority
Projects
None yet
Development

No branches or pull requests

3 participants