Develop #2450

WIFI-ROBOTS · 2019-05-08T14:16:02Z

The basics

I branched from develop
My pull request is against develop
My code follows the style guide

The details

Resolves

Proposed Changes

Reason for Changes

Test Coverage

Tested on:

Additional Information

Reverts hideChaff fix

Resolves issue #2380.

* Fixed mutator flyout being positioned incorrectly. * Changed flyout_horizonal and flyout_vertical to check this.targetWorkspace_.toolboxPosition instead of targetWorkspaceMetrics.toolboxPosition.

Angle picker's degree symbol left of number in both LTR and RTL.

* Propagate the visible state when blocks connect This fixes #1967. In rendered connections when connecting: - If the superior connection is hidden this hides the newly connected block. - If the superior connection isn't hidden it makes sure the block is visible. In rendered connections when disconnecting: - If the superior connection is hidden, make the disconnected block stack visible. TODO before review: - write tests. - update collapsed message * Add missing overrides * Add tests for hidden connections and fix a bug while disposing

Added isDirty_ Property to Fields

* Reorganize conditionals for block context menu * Disable comments and disabling in block factory

Add sauce labs to readme

Update version number to 1.20190419.0-develop

Moved RTL Demo Blocks so They Aren't Behind the Toolbox

Added isSerializable and SERIALIZABLE to Field

Documentation update

Added fromXml and toXml to Fields

These date back to before Blockly Games was separated from Blockly.

…2410)

Added updateColour to Field

Matches existing stripping of Google’s licence. Done with MIT’s permission. Resolves issue 2412.

…rade Update to webdriverio v5; fix resulting test breakages

Removed Explicitly Setting Variable Type to Two Single Quotes

Matches code in Blockly Games. No functional change.

Previously, if the XML of a toolbox contained a block ID, the first creation of this block would inherit this ID. Thus two realtime collaborators could realistically end up with conflict. Likewise, cut and paste could generate similar conflict.

I don’t care about whether we use the Element constants or the ubiquitously known 1 & 3 integers. But we had a mix. Also, ’x’ is usually used for horizontal location, ‘i’ is an iterator. No functional change.

* Rebuild and update version numbers * rebuild * Update version number to 1.20190419.0 * Resolve field angle overlap render problem * use block.getColourBorder() function

Add mocha tests to npm test

Refactored field.init into field.initView and field.initModel

googlebot · 2019-05-08T14:16:27Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

NeilFraser · 2019-05-08T14:59:11Z

I think this massive commit from develop to master is accidental. Closing.

alschmiedt and others added 30 commits April 5, 2019 11:59

core/generator.js

4fca167

Updates documentation

97d670c

Changed jsdoc

98a1c06

Localisation updates from https://translatewiki.net.

daf59f6

Reverts hideChaff fix

be4da5f

Merge pull request #2376 from alschmiedt/rever_hideChaff_fix

1bd7c7b

Reverts hideChaff fix

Degree symbol left of number in both LTR and RTL.

8c99ccc

Resolves issue #2380.

Localisation updates from https://translatewiki.net.

fd4bbe0

Fixed Mutator Flyout Being Positioned Incorrectly RTL (#2378)

b93253c

* Fixed mutator flyout being positioned incorrectly. * Changed flyout_horizonal and flyout_vertical to check this.targetWorkspace_.toolboxPosition instead of targetWorkspaceMetrics.toolboxPosition.

Merge pull request #2383 from google/fraser-angle

6bb2705

Angle picker's degree symbol left of number in both LTR and RTL.

Fixed visible floating point errors in number fields. (#2384)

f88c704

Added isDirty_ property to fields.

0617cc7

Merge pull request #2382 from BeksOmega/feature/FieldIsDirty

209a87e

Added isDirty_ Property to Fields

Localisation updates from https://translatewiki.net.

ae11235

Reorganize conditionals for block context menu (#2390)

bc77024

* Reorganize conditionals for block context menu * Disable comments and disabling in block factory

Add sauce labs to readme

0c0eeab

Merge pull request #2393 from google/rachel-fenichel-patch-2

a03f9b9

Add sauce labs to readme

Update version number to 1.20190419.0-develop

a82604d

Merge pull request #2394 from rachel-fenichel/update_version_num

9152b9d

Update version number to 1.20190419.0-develop

Moved RTL demo blocks so they aren't behind the toolbox.

5df7a39

Added isSerializable function and SERIALIZABLE property to fields.

e8573bc

Merge pull request #2397 from BeksOmega/fixes/RTLDemoBlocks

2e70b8e

Moved RTL Demo Blocks so They Aren't Behind the Toolbox

Changed mocha eslint config to extend root eslint config.

91b0e3d

Fixed lint errors

1488231

Merge pull request #2389 from BeksOmega/feature/SerializableFields

bc49f29

Added isSerializable and SERIALIZABLE to Field

Changed buttons and labels to respect <sep> elements in toolbox. (#2395)

9a9c661

Localisation updates from https://translatewiki.net.

fc80d71

Clarifies what statementToCode does

1ca7d6a

Merge pull request #2366 from alschmiedt/Documentation_Update

a84e86f

Documentation update

BeksOmega and others added 26 commits April 24, 2019 10:43

Added field_label_serializable. (#2399)

ce816b9

Removed setVisible from the public API (#2406)

5c4c816

Added fromXml and toXml to fields.

123b5dc

Merge pull request #2407 from BeksOmega/feature/FieldsXML

de6bf6e

Added fromXml and toXml to Fields

Delete two unused i18n scripts

c438188

These date back to before Blockly Games was separated from Blockly.

Fixed buttons being rendered as labels if they come after a label. (#…

79d75b9

…2410)

Added updateColour to field.

247aafa

Merge pull request #2413 from BeksOmega/feature/FieldUpdateColour

67ee390

Added updateColour to Field

Strip MIT’s licence out of compiled code.

8d4a73e

Matches existing stripping of Google’s licence. Done with MIT’s permission. Resolves issue 2412.

Update to webdriverio v5; fix resulting test breakages

da2a89e

Add firefox addon explicitly

00f84bb

Merge pull request #2424 from rachel-fenichel/testing/webdriverio_upg…

5983c3c

…rade Update to webdriverio v5; fix resulting test breakages

Add mocha tests + parsing to npm test

e77efa6

Fix test (matching fix in jsunit tests)

99dc9bb

Removed explicitly setting variable type to two single quotes.

3afcd23

Merge pull request #2425 from BeksOmega/fixes/fromXml

5e56b4a

Removed Explicitly Setting Variable Type to Two Single Quotes

Factor out licence stripping

e06916e

Matches code in Blockly Games. No functional change.

Use Element constants and ‘i’ variable.

834fa64

I don’t care about whether we use the Element constants or the ubiquitously known 1 & 3 integers. But we had a mix. Also, ’x’ is usually used for horizontal location, ‘i’ is an iterator. No functional change.

Resolve field angle overlap render problem (#2418)

44501f1

* Rebuild and update version numbers * rebuild * Update version number to 1.20190419.0 * Resolve field angle overlap render problem * use block.getColourBorder() function

Update comments

9e7becc

Merge pull request #2426 from rachel-fenichel/testing/run_mocha_tests

12a769b

Add mocha tests to npm test

Refactored field.init into field.initView and field.initModel

354d402

Localisation updates from https://translatewiki.net.

f065c78

Merge pull request #2427 from BeksOmega/fixes/InitView

4af436f

Refactored field.init into field.initView and field.initModel

typo fix in createVariable documentation in variable.js (#2443)

e25734f

NeilFraser closed this May 8, 2019

rachel-fenichel mentioned this pull request Jul 15, 2019

July 2019 release candidate (Q2 2019) #2644

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop #2450

Develop #2450

WIFI-ROBOTS commented May 8, 2019 •

edited

googlebot commented May 8, 2019

NeilFraser commented May 8, 2019

Develop #2450

Develop #2450

Conversation

WIFI-ROBOTS commented May 8, 2019 • edited

The basics

The details

Resolves

Proposed Changes

Reason for Changes

Test Coverage

Additional Information

googlebot commented May 8, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

NeilFraser commented May 8, 2019

WIFI-ROBOTS commented May 8, 2019 •

edited