Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: workspace paste #7356

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Aug 3, 2023

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes N/A

Proposed Changes

Deprecates the paste function on the workspace.

Reason for Changes

This function is not maintainable. It is hard coded to deserialize block data and workspace comment data. It cannot be backwards compatibily updated to use the new paster system, because it doesn't takes in the save state instead of the CopyData directly.

I see no reason to maintain this when we have better functionality in clipboard.paste.

For now it will continue to work as it did before (no breaking changes). But it will be deleted in v12.

Test Coverage

N/A This is just a deprecation :P

Documentation

N/A

Additional Information

N/A

@github-actions github-actions bot added the PR: fix Fixes a bug label Aug 3, 2023
@BeksOmega BeksOmega changed the base branch from operation-copy-that to develop August 11, 2023 18:58
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Aug 11, 2023
@BeksOmega BeksOmega marked this pull request as ready for review August 11, 2023 19:17
@BeksOmega BeksOmega requested a review from a team as a code owner August 11, 2023 19:17
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Aug 14, 2023
core/workspace_svg.ts Show resolved Hide resolved
@BeksOmega BeksOmega changed the title fix: deprecate workspace paste deprecate: workspace paste Aug 15, 2023
@github-actions github-actions bot added deprecation This PR deprecates an API. and removed PR: fix Fixes a bug labels Aug 15, 2023
@BeksOmega BeksOmega merged commit bb33531 into google:develop Aug 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This PR deprecates an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants