Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): wait for the workspace to render before starting test actions #7399

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes some tests that were flaky because the workspace wasn't always fully loaded.

Proposed Changes

In the testSetup function that loads a URL, wait for the workspace's block canvas to exist before returning.

Reason for Changes

The workspace must exist before the test actions start running. Checking for the block canvas is an easy test that uses standard webdriver APIs (waitForExist and selectors).

@rachel-fenichel rachel-fenichel requested a review from a team as a code owner August 16, 2023 20:28
@github-actions github-actions bot added the PR: fix Fixes a bug label Aug 16, 2023
@rachel-fenichel rachel-fenichel merged commit d32a13c into google:develop Aug 16, 2023
10 checks passed
@rachel-fenichel rachel-fenichel deleted the test_waits branch August 16, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants