Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad JSON state leaving events disabled #7501

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

BeksOmega
Copy link
Collaborator

The basics

The details

Resolves

Fixes #7486

Proposed Changes

Adds a try... finally block to make sure events are reenabled even if you load bad JSON.

Reason for Changes

Fix #7486

Test Coverage

Manual test steps do not reproduce.

Added a test that events are enabled even after bad JSON is loaded and deserialization throws.

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner September 18, 2023 19:47
@github-actions github-actions bot added the PR: fix Fixes a bug label Sep 18, 2023
@BeksOmega BeksOmega changed the title fix: json killing events fix: bad JSON state leaving events disabled Sep 18, 2023
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Sep 18, 2023
@BeksOmega BeksOmega merged commit 32c9daf into google:develop Sep 19, 2023
12 checks passed
@BeksOmega BeksOmega deleted the fix/json-killing-events branch May 14, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events stop firing after failed serialization (JSON)
2 participants