Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pasting with nothing selected #7561

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

BeksOmega
Copy link
Collaborator

The basics

The details

Resolves

Fixes #6848

Proposed Changes

Removes references to getSelected so you can paste while nothing is selected. Also reorganizes code to use Rect.contains

Reason for Changes

Bug fixing.

Test Coverage

Tested pasting when the original coords are inside and outside the viewport. Works correctly in both cases.

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner September 29, 2023 19:51
@github-actions github-actions bot added the PR: fix Fixes a bug label Sep 29, 2023
@BeksOmega BeksOmega linked an issue Sep 29, 2023 that may be closed by this pull request
1 task
@BeksOmega BeksOmega merged commit 48fc400 into google:osd Sep 29, 2023
7 checks passed
@BeksOmega BeksOmega deleted the fix/paste-in-viewport branch May 14, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paste block in viewport / near cursor
2 participants