Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: libraryBlocks exports #7886

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

devilhyt
Copy link
Contributor

@devilhyt devilhyt commented Feb 25, 2024

The basics

The details

Resolves

Fixes N/A

Proposed Changes + reasons

Blockly.libraryBlocks and Blockly.libraryBlocks.blocks were missing logic blocks and texts blocks respectively. They should be exported to ensure completeness and consistency. This PR addresses this issue.

Test Coverage

npm test succeeds.

Documentation

N/A

Additional Information

N/A

@devilhyt devilhyt requested a review from a team as a code owner February 25, 2024 12:08
Copy link

google-cla bot commented Feb 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Feb 25, 2024
@rachel-fenichel
Copy link
Collaborator

@devilhyt Thanks for your contribution!

@rachel-fenichel rachel-fenichel merged commit ca743cc into google:develop Mar 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants