Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent default undo #7946

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

BeksOmega
Copy link
Collaborator

The basics

The details

Resolves

Fixes #1915

Proposed Changes

Prevents default actions for events where we trigger undo or redo.

Test Coverage

Tested with my next PR, which relies on this behavior. (Undoing and redoing comment change events, which edit a text area)

Documentation

N/A

Additional Information

N/A

@github-actions github-actions bot added the PR: fix Fixes a bug label Mar 18, 2024
@BeksOmega BeksOmega changed the base branch from develop to rc/v11.0.0 March 18, 2024 21:51
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Mar 18, 2024
@BeksOmega BeksOmega marked this pull request as ready for review April 1, 2024 21:44
@BeksOmega BeksOmega requested a review from a team as a code owner April 1, 2024 21:44
Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please test well!

@BeksOmega BeksOmega merged commit b13f8f6 into google:rc/v11.0.0 Apr 2, 2024
7 checks passed
johnnesky pushed a commit to johnnesky/blockly that referenced this pull request Apr 13, 2024
* fix: prevent default undo

* chore: fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undo management: separate blocky and browser
2 participants