Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Assign to containerDiv blockyWidgetDiv if it already exists #7980

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

lotusotho
Copy link
Contributor

The basics

The details

Resolves

Work on #7819

Proposed Changes

If the div blockyWidgetDiv already exists, store it inside containerDiv doing the same document.querySelector, creating the constant container and appeding the already existing containerDiv as a child.

Reason for Changes

Covered in #7819

Test Coverage

Same tests passed before and after the PR.

Documentation

N/A

Additional Information

N/A

@lotusotho lotusotho requested a review from a team as a code owner March 30, 2024 19:21
@github-actions github-actions bot added the PR: fix Fixes a bug label Mar 30, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for rachel-fenichel April 1, 2024 21:17
core/widgetdiv.ts Outdated Show resolved Hide resolved
@lotusotho
Copy link
Contributor Author

Done! Thanks for the feedback!

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me =) Thanks for the fix!

@BeksOmega BeksOmega enabled auto-merge (squash) April 1, 2024 21:51
@BeksOmega BeksOmega merged commit d56f52c into google:develop Apr 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants