Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment keyboard shortcuts #8036

Merged

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Apr 16, 2024

The basics

The details

Resolves

Fixes #8006

Proposed Changes

Fixes the cut keyboard shortcuts to work with workspace comments.

Other shortcuts were fixed by other incremental fixes (e.g. fixing copy paste).

Test Coverage

Manually tested that delete, copy, cut, and paste all work with workspace comments.

Documentation

N/A

Additional Information

Dependent on #8035

@BeksOmega BeksOmega requested a review from gonfunko April 16, 2024 16:36
@github-actions github-actions bot added the PR: fix Fixes a bug label Apr 16, 2024
@BeksOmega BeksOmega changed the base branch from develop to rc/v11.0.0 April 17, 2024 16:11
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Apr 17, 2024
@BeksOmega BeksOmega marked this pull request as ready for review April 17, 2024 16:12
@BeksOmega BeksOmega requested a review from a team as a code owner April 17, 2024 16:12
@BeksOmega BeksOmega force-pushed the fix/comment-keyboard-shortcuts branch from ce0f667 to ed36e51 Compare April 17, 2024 20:20
@BeksOmega BeksOmega merged commit 41fe298 into google:rc/v11.0.0 Apr 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix and export keyboard shortcuts for workspace comments
2 participants