Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime linker path to pkg-config files #740

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

nigoroll
Copy link
Contributor

Otherwise libraries will not be found at runtime when installing to a path not included in the default runtime linker's path with programs linking brotli configured via pkg-config.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@nigoroll
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@nigoroll
Copy link
Contributor Author

the travis failure looks quite unrelated to me

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@eustas
Copy link
Collaborator

eustas commented Apr 12, 2019

Thanks. Sorry for super-long delay...

@eustas
Copy link
Collaborator

eustas commented Apr 12, 2019

Please rebase. Travis will be happy this time.

Otherwise libraries will not be found at runtime when installing to a
path not included in the default runtime linker's path with programs
linking brotli configured via pkg-config.
@nigoroll
Copy link
Contributor Author

rebased

@AppVeyorBot
Copy link

@eustas
Copy link
Collaborator

eustas commented May 15, 2020

Super. Thanks!

@eustas eustas merged commit 31754d4 into google:master May 15, 2020
@DimStar77
Copy link

DimStar77 commented Sep 1, 2020

GCC 10 seems not to be really happy with this. When building libsoup for example, I get:

[ 30s] cc: error: unrecognized command-line option ‘-R’

@Vogtinator
Copy link

#836 got opened for that failure

eustas added a commit that referenced this pull request Sep 2, 2020
eustas added a commit that referenced this pull request Sep 2, 2020
chylex pushed a commit to chylex/brotli that referenced this pull request Feb 19, 2021
Otherwise libraries will not be found at runtime when installing to a
path not included in the default runtime linker's path with programs
linking brotli configured via pkg-config.
chylex pushed a commit to chylex/brotli that referenced this pull request Feb 19, 2021
juj pushed a commit to Unity-Technologies/brotli that referenced this pull request May 13, 2023
Otherwise libraries will not be found at runtime when installing to a
path not included in the default runtime linker's path with programs
linking brotli configured via pkg-config.
juj pushed a commit to Unity-Technologies/brotli that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants