-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtime linker path to pkg-config files #740
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
the travis failure looks quite unrelated to me |
✅ Build brotli 1.0.0#1409 completed (commit 2c73bc0072 by @nigoroll) |
✅ Build brotli 1.0.0#1413 completed (commit 323233de1e by @nigoroll) |
Thanks. Sorry for super-long delay... |
Please rebase. Travis will be happy this time. |
Otherwise libraries will not be found at runtime when installing to a path not included in the default runtime linker's path with programs linking brotli configured via pkg-config.
rebased |
✅ Build brotli 1.0.0#1421 completed (commit ee76fe0e36 by @nigoroll) |
Super. Thanks! |
GCC 10 seems not to be really happy with this. When building libsoup for example, I get:
|
#836 got opened for that failure |
Otherwise libraries will not be found at runtime when installing to a path not included in the default runtime linker's path with programs linking brotli configured via pkg-config.
Otherwise libraries will not be found at runtime when installing to a path not included in the default runtime linker's path with programs linking brotli configured via pkg-config.
Otherwise libraries will not be found at runtime when installing to a path not included in the default runtime linker's path with programs linking brotli configured via pkg-config.