Fix -Wstrict-prototypes warnings #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envoy builds brotli with -Werror, and these strict prototypes are picked up by newer versions of clang.
eustas
approved these changes
Oct 25, 2022
pull bot
pushed a commit
to TheRakeshPurohit/skia
that referenced
this pull request
Oct 26, 2022
These changes pick up a few fixes for compile warnings including: - google/brotli#839 - google/brotli#985 Change-Id: Ic5bc4dbf85fdf840d5e7dfd505808dbb12505736 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/595317 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
juj
pushed a commit
to Unity-Technologies/brotli
that referenced
this pull request
May 13, 2023
Envoy builds brotli with -Werror, and these strict prototypes are picked up by newer versions of clang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy builds brotli with -Werror, and these strict prototypes are picked up by newer versions of clang.