Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the scale argument to encode_data.py #408

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Add the scale argument to encode_data.py #408

merged 2 commits into from
Dec 12, 2023

Conversation

tushuhei
Copy link
Member

@tushuhei tushuhei commented Dec 12, 2023 •
edited
Loading

This is a follow-up change for #358, which makes it easy to output weighted samples by specifying the scale as an argument for encode_data.py.

kojiishi
kojiishi previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/nit

scripts/encode_data.py Outdated Show resolved Hide resolved
@tushuhei @kojiishi
Fix typo
597acf0 
Co-authored-by: Koji Ishii <kojii@google.com>
@tushuhei tushuhei merged commit c3baa9f into main Dec 12, 2023
33 checks passed
@tushuhei tushuhei mentioned this pull request Dec 13, 2023
Merged
@tushuhei tushuhei deleted the scale-encode-data branch December 14, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojiishi kojiishi kojiishi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushuhei @kojiishi