Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .js extension for better module portability #79

Merged
merged 5 commits into from
Jul 29, 2022
Merged

Add .js extension for better module portability #79

merged 5 commits into from
Jul 29, 2022

Conversation

tushuhei
Copy link
Member

  • Add .js extention to imports
  • Remove ts-node from dependency

@tushuhei tushuhei requested a review from kojiishi July 28, 2022 22:33
kojiishi
kojiishi approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tushuhei tushuhei merged commit b767d79 into main Jul 29, 2022
@tushuhei tushuhei deleted the js-extension branch December 14, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojiishi kojiishi kojiishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushuhei @kojiishi