Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the P features #80

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Remove the P features #80

merged 4 commits into from
Aug 3, 2022

Conversation

tushuhei
Copy link
Member

@tushuhei tushuhei commented Aug 3, 2022

Remove the P (past results) features from feature extraction to make the processing faster with comparable segmentation accuracy.
This change includes:

  • updates on the feature extractor to ignore the P features and their derivatives.
  • a retrained Japanese model
  • a retrained Simplified Chinese model

@tushuhei tushuhei requested a review from kojiishi August 3, 2022 02:57
kojiishi
kojiishi approved these changes Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tushuhei tushuhei merged commit 89c56db into main Aug 3, 2022
@tushuhei tushuhei mentioned this pull request Oct 24, 2022
Closed
@tushuhei tushuhei deleted the no-past-feature2 branch October 24, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojiishi kojiishi kojiishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushuhei @kojiishi