-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore CPU clock for riscv64 #2364
Conversation
Hi @carlosedp. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Strange... It failed with:
|
I don't think this is your PR, as it has occurred in #2367 as well |
Yes, seems like a flaky one. /test pull-cadvisor-e2e |
You will need to rebase on top of #2370 to fix the test. |
Damn, I've cherry-picked instead of rebase... is that OK? |
I don't think that is what we want. There may be a quicker way to do it, but from your current state, you should be able to: # undo the cherry-pick
git reset --hard HEAD~
# if you haven't already set your upstream repo
git remote add upstream https://github.com/google/cadvisor.git
# fetch my changes, rebase, and push
git fetch upstream
git rebase upstream/master
git push origin riscv64 |
Done... sorry about the noise ;) |
Its all good, thanks for your contribution! |
Thanks David! |
Add riscv64 to clock speed ignore list.