New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreleased Resource: Streams #426

Closed

QiAnXinCodeSafe opened this issue Dec 9, 2019 · 1 comment

QiAnXinCodeSafe commented Dec 9, 2019

caliper/caliper-runner/src/main/java/com/google/caliper/runner/config/LoggingConfigLoader.java

Line 58 in e8142ee

fis = closer.register(new FileInputStream(loggingPropertiesFile));

The program can potentially fail to release a system resource.

Member

nick-someone commented Dec 9, 2019

Guava's Closer, when properly used as it is done here, closes the resource in question.

nick-someone closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment