Add some features to CameraView #218

sibelius · 2017-12-10T19:58:05Z

this is based on @expo work https://github.com/expo/expo/tree/master/android/cameraview

the idea is to consume this package on https://github.com/lwansbrough/react-native-camera (check this react-native-camera/react-native-camera#1031)

googlebot · 2017-12-10T19:58:10Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

sibelius · 2017-12-11T10:24:38Z

I've signed the CLA, I don't know why this does not worked

googlebot · 2017-12-11T10:24:41Z

CLAs look good, thanks!

sibelius · 2017-12-12T16:27:25Z

@yaraki can you take a look on this any time soon?

brentvatne · 2017-12-12T18:34:43Z

@sibelius - the code that you used here is BSD licensed: https://github.com/expo/expo/blob/master/LICENSE -- it requires attribution and retaining the copyright notice. I'm not sure how this interacts with Google's CLA here, it might invalidate this PR.

sibelius · 2017-12-12T19:22:59Z

should a put the expo LICENSE on THIRD-PARTY-LICENSES?

elementlo · 2018-01-19T01:29:10Z

I want to know now how to get the preview data , I see there is only method recording video but no one callback the preview frame , some one can help me? @sibelius

aalices · 2018-01-31T10:08:26Z

@elementlo you should use setScanning(true) on you CameraView and then onPreviewFrame should be invoked within a Callback you previously added.

elementlo · 2018-02-06T01:30:28Z

@aalices OK , I'll have a try first , thank you.

dubiao · 2018-04-26T11:52:19Z

library/src/main/api21/com/google/android/cameraview/Camera2.java

+            if (mIsScanning) {
+                mPreviewRequestBuilder.addTarget(mScanImageReader.getSurface());
+            }
+            mCamera.createCaptureSession(Arrays.asList(surface, mStillImageReader.getSurface(),


There is an output while executing this statement:

E/CameraCaptureSession: Session 0: Failed to create capture session; configuration failed

This log is print from the internal source code. I researched but not get any progress.
I tried createCaptureSession with a list of two surface bugs got over, but Then I can not use the both surface as output surface.

So things become bad: I can only use one imagereader of the two, capture it or preview it.

Do you have any idea?

bipinvaylu · 2019-01-10T07:54:08Z

Hi, When do we have this PR gets merged? I want to do Preview, Recording and Preview frame processing parallel. I hope this PR incorporating those things. For more details, Please find my use case here: https://stackoverflow.com/questions/54091648/camera-2-api-to-preview-record-and-extract-the-preview-frame-to-firebase-face-d

bipinvaylu · 2019-01-10T08:44:17Z

Hey @sibelius, Closed PR without merge, It would be a great help if you can share latest codebase link here. I can't able to find the entria:G branch here.

sibelius · 2019-01-10T09:18:27Z

We moved our efforts to react native camera, the code and improvements are there

If you want to contribute ther it would be great

bipinvaylu · 2019-01-10T09:33:12Z

Okay, Thanks for the response, So now you are developing the camera stuff into React Native, not in Native Android. That's nice. Atm, I am looking for the Previewing, Recording and Frame processing at the same time. As like I mentioned in my SO question.

sibelius · 2019-01-10T09:40:47Z

You can do that using ML Kit

bipinvaylu · 2019-01-10T11:54:55Z

Yup, But I am unable to extract the Image/Frame when recording is going on. With Preview only, I am getting Image/Frames. Any help/insight will be appreciated on this question: https://stackoverflow.com/questions/54091648/camera-2-api-to-preview-record-and-extract-the-preview-frame-to-firebase-face-d

sibelius added 5 commits December 10, 2017 10:10

make constants public

2d56ccd

add more methods to cameraview

639e88d

fix camera1 and camera2 view impl

792d150

update build.gradle

e7882a5

more changes

08c776d

googlebot added the cla: no label Dec 10, 2017

This was referenced Dec 10, 2017

1.0 Changes, TODO, and RFC react-native-camera/react-native-camera#246

Closed

Zoom Feature #190

Open

Feature request: record video #6

Open

How to add manual focus #35

Open

googlebot added cla: yes and removed cla: no labels Dec 11, 2017

This was referenced Dec 11, 2017

split camera component to a separate package expo/expo#1097

Closed

import com.google.android.cameraview.Constants; is not public #217

Open

Set / Get Aspect Ratio #151

Open

If i want to recorder video how to achieve? #142

Open

This was referenced Dec 12, 2017

Add Preview Callback #171

Open

Preview Data Callback #186

Open

Switch Aspect Ratio It Crashed #219

Open

dubiao reviewed Apr 26, 2018

View reviewed changes

giskook mentioned this pull request May 25, 2018

Color filter on Camera view #216

Open

eqyiel mentioned this pull request Jun 18, 2018

com.google.cameraview: should be a subtree react-native-camera/react-native-camera#1639

Closed

sibelius closed this Jan 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add some features to CameraView #218

Add some features to CameraView #218

sibelius commented Dec 10, 2017

googlebot commented Dec 10, 2017

sibelius commented Dec 11, 2017

googlebot commented Dec 11, 2017

sibelius commented Dec 12, 2017

brentvatne commented Dec 12, 2017 •

edited

Loading

sibelius commented Dec 12, 2017

elementlo commented Jan 19, 2018

aalices commented Jan 31, 2018

elementlo commented Feb 6, 2018

dubiao Apr 26, 2018

bipinvaylu commented Jan 10, 2019

bipinvaylu commented Jan 10, 2019

sibelius commented Jan 10, 2019 •

edited

Loading

bipinvaylu commented Jan 10, 2019

sibelius commented Jan 10, 2019

bipinvaylu commented Jan 10, 2019

Add some features to CameraView #218

Add some features to CameraView #218

Conversation

sibelius commented Dec 10, 2017

googlebot commented Dec 10, 2017

sibelius commented Dec 11, 2017

googlebot commented Dec 11, 2017

sibelius commented Dec 12, 2017

brentvatne commented Dec 12, 2017 • edited Loading

sibelius commented Dec 12, 2017

elementlo commented Jan 19, 2018

aalices commented Jan 31, 2018

elementlo commented Feb 6, 2018

dubiao Apr 26, 2018

Choose a reason for hiding this comment

bipinvaylu commented Jan 10, 2019

bipinvaylu commented Jan 10, 2019

sibelius commented Jan 10, 2019 • edited Loading

bipinvaylu commented Jan 10, 2019

sibelius commented Jan 10, 2019

bipinvaylu commented Jan 10, 2019

brentvatne commented Dec 12, 2017 •

edited

Loading

sibelius commented Jan 10, 2019 •

edited

Loading