You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the public functions in package github.com/google/capslock/analyzer accept a *interesting.Classifier as an argument. For external usage of this package, it would be beneficial, if these functions would instead accept an interface as follows:
This would allow users of this package to write their own classifiers or to extend the provided classifiers e.g. by wrapping them (middleware approach).
I am happy to provide a PR for this.
The text was updated successfully, but these errors were encountered:
breml
added a commit
to breml/capslock
that referenced
this issue
Sep 17, 2023
Currently the public functions in package
github.com/google/capslock/analyzer
accept a*interesting.Classifier
as an argument. For external usage of this package, it would be beneficial, if these functions would instead accept an interface as follows:This would allow users of this package to write their own classifiers or to extend the provided classifiers e.g. by wrapping them (middleware approach).
I am happy to provide a PR for this.
The text was updated successfully, but these errors were encountered: