Describe JSON conversion and clean up formatting. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/langdef.md
Outdated
|
|
||
| CEL Data | JSON Data | ||
| ---------------------------------------------------- | --------- | ||
| `int` | Number if in interoperable range, otherwise decimal String. |
There was a problem hiding this comment.
Let's mention that the interoperable range is -(2^53 - 1) to 2^53 - 1.
doc/langdef.md
Outdated
| double NaN | String "NaN" | ||
| `bytes` | String of base64-encoded bytes | ||
| message | JSON conversion of protobuf message. | ||
| `list` with non-convertible elements | none |
There was a problem hiding this comment.
Is it worth mentioning the lists and maps with convertible elements?
There was a problem hiding this comment.
Yes. I've updated the list/map descriptions here and in the table above to distinguish bi-convertible, convertible, and non-convertible values.
doc/langdef.md
Outdated
|
|
||
| ### List of Standard Definitions | ||
|
|
||
| TODO https://issuetracker.google.com/67014381 : have better descriptions. The |
There was a problem hiding this comment.
This issue has been archived, but there is one currently open within the cel-go repository to create a better docgen tool.
|
PTAL |
TristonianJones
approved these changes
Oct 11, 2019
|
Closes #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.