This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Adding filter transformer and tests. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,9 @@ typedef dynamic FieldAccessor(dynamic item, dynamic key); | |||
| /** | |||
| * Given list of items, dimensions and facts, compute | |||
| * aggregates (COUNT, SUM, MIN, MAX) for facts at each dimension level. | |||
| * | |||
| * [Design/API Document] | |||
| * (https://docs.google.com/a/google.com/document/d/1m6xGU9KF3nWPRjwILGRFhoi1_9mCCkCPIs0OxsaoQMU/view) | |||
There was a problem hiding this comment.
Remove this comment - cannot access the document, possibly add a TODO to document the design and API.
Implement charts api v2
| _registerListeners() { | ||
| _dataSubscriptions.dispose(); | ||
|
|
||
| if(_data is ChartDataObservable) { |
There was a problem hiding this comment.
This will need merge, because ChartDataObserverable does not exist anymore.
|
Please merge and update the pull request. |
merge charts.dart Modification base on comments
…/charted into filter-transformer Conflicts: lib/charts/charts.dart lib/charts/transformers/aggregation_transformer.dart lib/charts/transformers/filter_transformer.dart test/charts/transformers/aggregation_transformer_test.dart test/charts/transformers/chain_transform_test.dart
psunkari
added a commit
that referenced
this pull request
Aug 14, 2014
Adding filter transformer and tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.