Use new RSA key creation APIs when available #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're looking to make the RSA struct in BoringSSL opaque, to unblock a host of improvements around that type. As part of that, we'll need to fix existing callers touching the struct, including Conscrypt. In principle, OpenSSL already had APIs RSA_set0_* for this, but they are tedious to use. They also don't allow one to make an RSA key without e, but Conscrypt needs to support this. (Unless we can guess e based on n and d because it's almost certainly 3 or 65537.) They also do a weird deferred initialization thing that causes us some problems in BoringSSL. In an attempt to fix this, we've added new APIs in https://boringssl-review.googlesource.com/c/boringssl/+/59386, including some specifically for Conscrypt's use case.
prbprbprb
approved these changes
May 4, 2023
davidben
added a commit
to davidben/conscrypt
that referenced
this pull request
May 5, 2023
This fixes the test failures introduced by google#1133. Not sure why the issue manifested the way it did, but this seems to fix it.
prbprbprb
pushed a commit
that referenced
this pull request
May 5, 2023
This fixes the test failures introduced by #1133. Not sure why the issue manifested the way it did, but this seems to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're looking to make the RSA struct in BoringSSL opaque, to unblock a host of improvements around that type. As part of that, we'll need to fix existing callers touching the struct, including Conscrypt.
In principle, OpenSSL already had APIs RSA_set0_* for this, but they are tedious to use. They also don't allow one to make an RSA key without e, but Conscrypt needs to support this. (Unless we can guess e based on n and d because it's almost certainly 3 or 65537.) They also do a weird deferred initialization thing that causes us some problems in BoringSSL.
In an attempt to fix this, we've added new APIs in https://boringssl-review.googlesource.com/c/boringssl/+/59386, including some specifically for Conscrypt's use case.