Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 8 style SNI hostname to OpenSSLEngineImpl #155

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

kruton
Copy link
Contributor

@kruton kruton commented Mar 20, 2017

The SNIHostName, et al., support was lacking from OpenSSLEngineImpl
causing endpoint protocol identification to fail in Netty tests.

Copy link
Contributor

@nmittler nmittler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kruton can you add a simple test or two for this?

@kruton
Copy link
Contributor Author

kruton commented Mar 20, 2017

This would be in the integration tests in Android's libcore project.

@kruton kruton force-pushed the sni-engine branch 2 times, most recently from 095c714 to 50e3210 Compare March 20, 2017 22:10
@kruton
Copy link
Contributor Author

kruton commented Mar 20, 2017

Here are the two tests I made for this in the libcore integration tests:
https://android-review.googlesource.com/355187
https://android-review.googlesource.com/355188

Adding this actually found a bug in the existing endpointIdentificationAlgorithm tests. Also the added test found the problem you ran into with CertificateException being propagated instead of SSLHandshakeException.

@nmittler
Copy link
Contributor

@kruton you'll want to rebase on the latest master and add any new public getters/setters to the Conscrypt class.

@nmittler
Copy link
Contributor

@kruton
Copy link
Contributor Author

kruton commented Mar 21, 2017

Maybe I can use a pared-down Conscrypt Android build manifest in Travis-CI builds to make sure we don't have a regression until #153 is 100% fixed. That will allow us to run the Android tests until we can separate the tests into its own project.

The SNIHostName, et al., support was lacking from OpenSSLEngineImpl
causing endpoint protocol identification to fail in Netty tests.
@nmittler
Copy link
Contributor

Sounds reasonable ... You have something in mind? Want to throw together a PR?

@kruton
Copy link
Contributor Author

kruton commented Mar 21, 2017

Yes, I will put it together.

@kruton kruton merged commit 9e569de into google:master Mar 21, 2017
nmittler pushed a commit that referenced this pull request Mar 29, 2017
The SNIHostName, et al., support was lacking from OpenSSLEngineImpl
causing endpoint protocol identification to fail in Netty tests.
@kruton kruton deleted the sni-engine branch November 11, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants