Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vpclmulqdq should be pclmulqdq #2

Closed
Myriachan opened this issue Feb 7, 2018 · 2 comments
Closed

vpclmulqdq should be pclmulqdq #2

Myriachan opened this issue Feb 7, 2018 · 2 comments
Assignees
@gchatelet
Milestone
v0.2.0

Comments

@Myriachan
Copy link

vpclmulqdq should be pclmulqdq. The "v" version of the instruction simply means to encode the instruction in AVX format instead of SSE format.
@gchatelet gchatelet self-assigned this Feb 8, 2018
@Myriachan
Copy link
Author

I made a mistake. vpclmulqdq is now a future feature that is actually a vectorized multiply. The code was correct before.
https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf

However, there is a separate pclmulqdq (old version) bit that should be added: leaf 1 ecx bit 1.

I am sorry about this; I didn't know about the newest information.

@gchatelet gchatelet reopened this Feb 9, 2018
@gchatelet
Copy link
Collaborator

It's fine, it happens :) I should have double checked.
Do you mind opening another issue for the missing feature? I'll revert the commit. Thx!

gchatelet added a commit that referenced this issue Jan 17, 2019
@gchatelet
# This is a combination of 13 commits.
abf08af 
# This is the 1st commit message:

Update macros to detect mips64 and differentiate between x86 32/64.

# This is the commit message #2:

Fix Mips32 and add an alias for Mips32/64.

# This is the commit message #3:

Allow specifying cmake generator.

# This is the commit message #4:

Remove unavailable MSVC version and test Ninja on travis

# This is the commit message #5:

Add ninja build.

# This is the commit message #6:

Use Ninja by default

# This is the commit message #7:

Show tests output

# This is the commit message #8:

Defaulting env to Ninja in the build matrix

# This is the commit message #9:

Defaulting env to Ninja in the build matrix

# This is the commit message #10:

Do not use ninja on OSX

# This is the commit message #11:

Fix test output.

# This is the commit message #12:

Fix running tests

# This is the commit message #13:

Fix running tests
@gchatelet gchatelet added this to the v0.2.0 milestone Apr 30, 2019
jwatte pushed a commit to jwatte/cpu_features that referenced this issue Dec 22, 2021
Fix the build for M1 MacBooks
8715830 
It turns out, MACOS is a perfectly fine OS to support aarch64 (through its name
arm64.)

The only thing missing was the appropriate check in impl_aarch64, plus renaming
the file to match that it's really for any OS that has the CPU.

jwatte@Jons-MBP build % make test
Running tests...
Test project /Users/jwatte/cpu_features/build
    Start 1: bit_utils_test
1/4 Test google#1: bit_utils_test ...................   Passed    0.06 sec
    Start 2: string_view_test
2/4 Test google#2: string_view_test .................   Passed    0.04 sec
    Start 3: stack_line_reader_test
3/4 Test google#3: stack_line_reader_test ...........   Passed    0.04 sec
    Start 4: cpuinfo_aarch64_test
4/4 Test google#4: cpuinfo_aarch64_test .............   Passed    0.12 sec
@jwatte jwatte mentioned this issue Dec 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gchatelet gchatelet

Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
2 participants
@gchatelet @Myriachan