Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark MapBindings APIs as @Beta or something similar, so as to avoid API commitments in 2.0 #138

Closed
cgruber opened this issue Mar 26, 2015 · 2 comments
Closed

Mark MapBindings APIs as @Beta or something similar, so as to avoid API commitments in 2.0 #138

cgruber opened this issue Mar 26, 2015 · 2 comments
Assignees
@gk5885
Milestone
Dagger 2.0 Release

Comments

@cgruber
Copy link

cgruber commented Mar 26, 2015

We haven't experimented with the MapBindings APIs enough to be confident that they're right, and we have too many folks in-migration from Dagger 1.0 without mapbindings who use a Set then a @Provides method that indexes that set into a map as a workaround. As such, the feature simply hasn't been exercised enough.

We'll leave it available, but 2.0 will provide no API guarantees.
@cgruber cgruber added this to the Dagger 2.0 Release milestone Mar 26, 2015
@gk5885
Copy link

gk5885 commented Mar 31, 2015

+1 to this plan

@cgruber
Copy link
Author

cgruber commented Apr 7, 2015

Implemented in #145

@cgruber cgruber closed this as completed Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gk5885 gk5885

Labels
None yet
Projects
None yet
Milestone
Dagger 2.0 Release
Development

No branches or pull requests
2 participants
@cgruber @gk5885