Docsy 0.4.0 migration instructions and doc updates #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
commented
Jun 24, 2022
|
|
||
| git submodule update --init --recursive | ||
| {{% /alert %}} | ||
| 1. Ensure you have an up to date local copy of your site files cloned from your repo. |
There was a problem hiding this comment.
I simplified this because, IMHO, we shouldn't be telling folks how to clone their own repos -- in particular because we don't know the flags that they require.
There was a problem hiding this comment.
Works for me, the only reason we used to have to remind people to recurse into the submodules was because of FontAwesome and Bootstrap, we had a lot of users who cloned sites that didn't work because they were missing those submodules.
3 tasks
|
This looks great! Do you want to hold off on merging or can I merge now? |
|
Thanks for the docs tweak and LGTM. This is ready to merge now. |
fekete-robert
pushed a commit
to fekete-robert/docsy
that referenced
this pull request
Sep 13, 2022
* Docsy 0.4.0 migration instructions and doc updates * Also drop --recurse-submodules * tiny fix Co-authored-by: LisaFC <lcarey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: