Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module setup: update docsy/dependencies to tip of main #1229

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

deining
Copy link
Collaborator

@deining deining commented Sep 6, 2022

This PR is the continuation of #1216: now that we have the commit hash from this PR, we update the module docsy/dependencies to this commit. Thus module setup will work with tip of branch again. This eventually fixes #1214, which was closed prematurely.

@deining deining added the module label Sep 6, 2022
@deining deining requested a review from LisaFC September 6, 2022 20:14
@dholbach
Copy link
Contributor

dholbach commented Sep 7, 2022

Should font-awesome be at

github.com/FortAwesome/Font-Awesome v0.0.0-20220725174816-701d64a89432

probably to be up to date with 6.1.2?

@dholbach
Copy link
Contributor

dholbach commented Sep 7, 2022

And github.com/twbs/bootstrap v4.6.2+incompatible as well.

@deining
Copy link
Collaborator Author

deining commented Sep 7, 2022

Should font-awesome be at

github.com/FortAwesome/Font-Awesome v0.0.0-20220725174816-701d64a89432

probably to be up to date with 6.1.2?

And github.com/twbs/bootstrap v4.6.2+incompatible as well.

Yes and yes. Both updates are addressed already with my PR #1218.

@LisaFC LisaFC merged commit 6488360 into google:main Sep 12, 2022
@deining deining deleted the issue-1214 branch September 12, 2022 18:17
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module installation broken with tip of main
3 participants