Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark mode] Left-nav and taxonomy color fixes #1952

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Apr 29, 2024

Preview: https://deploy-preview-1952--docsydocs.netlify.app/docs/

@chalin chalin force-pushed the chalin-im-leftnav+taxonomy-darkm-2024-04-25 branch from 6e4a51f to c140317 Compare April 29, 2024 14:46
@chalin chalin mentioned this pull request Apr 29, 2024
26 tasks
@chalin chalin force-pushed the chalin-im-leftnav+taxonomy-darkm-2024-04-25 branch from c140317 to b8f69b3 Compare April 29, 2024 14:49
@chalin chalin added this to the 24Q2 milestone Apr 29, 2024
@chalin
Copy link
Collaborator Author

chalin commented Apr 29, 2024

/cc @cartemp - open-telemetry/opentelemetry.io#4023 (comment)

@chalin
Copy link
Collaborator Author

chalin commented Apr 29, 2024

Hi @deining: do the new dark-mode compatible taxonomy element colors work for you?

@deining
Copy link
Collaborator

deining commented Apr 29, 2024

Hi @deining: do the new dark-mode compatible taxonomy element colors work for you?

Yes, they do, thanks for implementing!

Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin merged commit 8fe1be5 into google:main Apr 29, 2024
11 checks passed
@chalin chalin deleted the chalin-im-leftnav+taxonomy-darkm-2024-04-25 branch April 29, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dark mode] Left-nav color and contrast adjustments are needed Light/dark mode: display of tags/categories
3 participants