Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fr.toml: ui_search #929

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Update fr.toml: ui_search #929

merged 1 commit into from
Jun 29, 2022

Conversation

arnaudlevy
Copy link
Contributor

The text is too long (or the field is too small)!
Capture d’écran 2022-03-12 à 09 16 04

chalin
chalin requested changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'abord je propose "Chercher dans ce site..." (nous gagnons deux lettres), et apres, nous pourrions ajouter un title au champ de recherche, pour qu'un "hover" montre tout le text, comme ceci:

image

Qu'en pensez-vous?

@chalin chalin self-assigned this Mar 14, 2022
@arnaudlevy
Copy link
Contributor Author

Merci !
Je pense que "Rechercher" est mieux, il ne faut pas que ça sorte du champ du tout, et l'ambiguïté est faible.
On peut aussi élargir le champ.

@arnaudlevy @chalin
Update fr.toml
b87d0f6 
The text is too long (or the field is too small)!
chalin
chalin approved these changes Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon, allons-y avec ta proposition! Merci pour la contribution et ta patience!

@chalin chalin changed the title Update fr.toml Update fr.toml: ui_search Jun 29, 2022
@chalin chalin merged commit 4cdc646 into google:main Jun 29, 2022
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
@arnaudlevy @fekete-robert
Update fr.toml: ui_search (google#929)
4e88139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees

@chalin chalin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaudlevy @chalin