Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] ieee.h: Wrong QuietNaN bit check on mips* architectures #171

Closed
cdluminate opened this issue Jan 9, 2022 · 1 comment · Fixed by #172
Closed

[bug] ieee.h: Wrong QuietNaN bit check on mips* architectures #171

cdluminate opened this issue Jan 9, 2022 · 1 comment · Fixed by #172

Comments

@cdluminate
Copy link
Contributor

double-conversion 3.1.7 has introduced some quiet_nan bit checks for the Single and Double classes defined in double-conversion/ieee.h. But the code failed to pass the test on the mips* architectures according to Debian buildlogs: https://buildd.debian.org/status/package.php?p=double%2dconversion

According to wikipedia, https://en.wikipedia.org/wiki/NaN, the mips* architecture regard the is_quiet/is_signaling bit the reversed way compared to other architectures. Thus we have to flip the logic in the corresponding new code. I've written a preliminary patch against this bug: https://salsa.debian.org/science-team/double-conversion/-/blob/lumin/debian/patches/fix-mips.patch

I'll submit it as a patch when I finished tests.
@cdluminate cdluminate changed the title [bug] ieee.h: Wrong QuietNaN bit on mips* architectures [bug] ieee.h: Wrong QuietNaN bit check on mips* architectures Jan 9, 2022
@floitsch
Copy link
Collaborator

floitsch commented Jan 9, 2022

Thanks for the report.

Looking forward to the patch.

@cdluminate cdluminate mentioned this issue Jan 10, 2022
Merged
floitsch pushed a commit that referenced this issue Jan 10, 2022
@cdluminate
ieee.h: Fix QuietNan check for MIPS* and PA-RISC architectures. (#172)
03c48d6 
Please refer to https://en.wikipedia.org/wiki/NaN, the MIPS* and PA-RISC
(also known as HPPA) architectures regard the "is_quiet/is_signaling" bit
the reversed way compared to other architectures.

This patch fixes #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ieee.h: Fix QuietNan check for MIPS* and PA-RISC architectures.
2 participants
@floitsch @cdluminate