Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNaCl and DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS #67

Closed
jungshik opened this issue May 2, 2018 · 2 comments
Closed

PNaCl and DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS #67

jungshik opened this issue May 2, 2018 · 2 comments
Assignees

Comments

@jungshik
Copy link

jungshik commented May 2, 2018

In utils.h, DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS is set to 1 only for architectures known to work correctly (and it's unset for architectures known not to support). For unknown architectures, a compile time error is emitted with #error pragma.

PNaCl (portable native client) is taken to '#error' branch. This was discovered when compiling ICU 61 for Chromium (ICU 61 does have a version of double-conversion library).

#elif defined(__pnacl__) || defined(__native_client__)
#undef DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS
#else // final #else
#error "Target ... not detected s supported by Double-Conversion
#endif 

Perhaps adding one more #elif branch for PNaCl (and NaCl) as above would work.

ICU bug : https://ssl.icu-project.org/trac/ticket/13750

@floitsch floitsch self-assigned this May 5, 2018
floitschG added a commit to floitschG/double-conversion that referenced this issue May 7, 2018
@floitschG
Copy link
Contributor

Could you please review (and maybe test) #69

Thanks.

@jungshik
Copy link
Author

jungshik commented Jun 5, 2018

Sorry for missing your ping. Thank you for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants