Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Should we make Eager an argument of @Singleton? #12

Closed
yozo1984 opened this issue Jul 23, 2013 · 3 comments · Fixed by #14
Closed

Should we make Eager an argument of @Singleton? #12

yozo1984 opened this issue Jul 23, 2013 · 3 comments · Fixed by #14

Comments

@yozo1984
Copy link
Contributor

To be more specific,

@Singleton(eager=True)  # default is false
@wesalvaro
Copy link
Contributor

I originally thought there might be a case when you'd want something eager that wouldn't be a Singleton, but I can't think of it now, so I support this change. Can you think of an eager factory example?

@yozo1984
Copy link
Contributor Author

eager factory doesn't seem to be right. A non-singleton factory should return new instance every time. Then how can it be eager?

@wesalvaro
Copy link
Contributor

Agreed.
On Jul 23, 2013 2:25 PM, "Zak Tsai" notifications@github.com wrote:

eager factory doesn't seem to be right. A non-singleton factory should
return new instance every time. Then how can it be eager?


Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-21447227
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants