Remove DoNoCall flags for checking Thread.run and various `getCla…

…ss` methods. PiperOrigin-RevId: 500682006
google · Jan 9, 2023 · ee1e777 · ee1e777
1 parent bb9ede9
commit ee1e777
Showing 1 changed file with 0 additions and 26 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/DoNotCallChecker.java b/core/src/main/java/com/google/errorprone/bugpatterns/DoNotCallChecker.java
@@ -38,7 +38,6 @@
 import com.google.common.collect.ImmutableListMultimap;
 import com.google.common.collect.ImmutableMap;
 import com.google.errorprone.BugPattern;
-import com.google.errorprone.ErrorProneFlags;
 import com.google.errorprone.VisitorState;
 import com.google.errorprone.bugpatterns.BugChecker.CompilationUnitTreeMatcher;
 import com.google.errorprone.bugpatterns.BugChecker.MethodTreeMatcher;
@@ -68,29 +67,12 @@
 import java.util.Map;
 import java.util.Optional;
 import java.util.stream.Stream;
-import javax.inject.Inject;
 import javax.lang.model.element.Modifier;
 
 /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
 @BugPattern(name = "DoNotCall", summary = "This method should not be called.", severity = ERROR)
 public class DoNotCallChecker extends BugChecker
     implements MethodTreeMatcher, CompilationUnitTreeMatcher {
-  private final boolean checkNewGetClassMethods;
-  private final boolean checkThreadRun;
-
-  @Inject
-  public DoNotCallChecker(ErrorProneFlags flags) {
-    checkNewGetClassMethods =
-        flags.getBoolean("DoNotCallChecker:CheckNewGetClassMethods").orElse(true);
-    checkThreadRun = flags.getBoolean("DoNotCallChecker:CheckThreadRun").orElse(true);
-  }
-
-  private static final Matcher<ExpressionTree> STACK_TRACE_ELEMENT_GET_CLASS =
-      instanceMethod().onExactClass("java.lang.StackTraceElement").named("getClass");
-
-  private static final Matcher<ExpressionTree> ANY_GET_CLASS =
-      instanceMethod().anyClass().named("getClass");
-
   private static final Matcher<ExpressionTree> THREAD_RUN =
       instanceMethod().onDescendantOf("java.lang.Thread").named("run").withNoParameters();
 
@@ -328,14 +310,6 @@ public Void visitMemberReference(MemberReferenceTree tree, Void unused) {
       private void handleTree(ExpressionTree tree, MethodSymbol symbol) {
         for (Map.Entry<Matcher<ExpressionTree>, String> matcher : THIRD_PARTY_METHODS.entrySet()) {
           if (matcher.getKey().matches(tree, state)) {
-            if (!checkNewGetClassMethods
-                && ANY_GET_CLASS.matches(tree, state)
-                && !STACK_TRACE_ELEMENT_GET_CLASS.matches(tree, state)) {
-              return;
-            }
-            if (!checkThreadRun && THREAD_RUN.matches(tree, state)) {
-              return;
-            }
             state.reportMatch(buildDescription(tree).setMessage(matcher.getValue()).build());
             return;
           }