Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash on 'arrow' switches in FallThrough #2124

Merged
merged 1 commit into from Jan 19, 2021

Conversation

copybara-service[bot]
Copy link
Contributor

@copybara-service copybara-service bot commented Jan 19, 2021

Don't crash on 'arrow' switches in FallThrough

arrow switches don't fall through, so this check doesn't apply to them,
just exiting gracefully is all we need to do here.

Fixes #2118

@google-cla google-cla bot added the cla: yes label Jan 19, 2021
arrow switches don't fall through, so this check doesn't apply to them,
just exiting gracefully is all we need to do here.

Fixes #2118

PiperOrigin-RevId: 352602004
@copybara-service copybara-service bot merged commit b84b80c into master Jan 19, 2021
5 checks passed
@copybara-service copybara-service bot deleted the test_352195993 branch Jan 19, 2021
@openamiguel openamiguel mentioned this pull request Jul 27, 2021
copybara-service bot pushed a commit that referenced this issue Aug 12, 2021
Fix for Issue #2393 (WrongOneof mishandles new style switch statement) based on PR #2371 and PR #2124.

Fixes #2470

COPYBARA_INTEGRATE_REVIEW=#2470 from openamiguel:master 148cf4d
PiperOrigin-RevId: 390456921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant