Fix for the memory leak when multiple batch runs are triggered #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default glibc memory allocator is created memory fragmentations and is causing the off-heap memory of the application to grow indefinitly. This is replaced by the jemalloc allocator which avoids such problems. Refer google#777 for more details
bashir2
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Thanks @chandrashekar-s for this fix. Please feel free to merge after addressing minor comments below.
The default glibc memory allocator is created memory fragmentations and is causing the off-heap memory of the application to grow indefinitly. This is replaced by the jemalloc allocator which avoids such problems. Refer google#777 for more details
bashir2
approved these changes
Sep 11, 2023
|
@bashir2 Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default glibc memory allocator is creating memory fragmentations and not returning memory to kernel gracefully (please refer to glibc bugzilla and glibc manual). This is replaced by the jemalloc allocator which avoids such problems.
Refer #777 for more details
Description of what I changed
E2E test
TESTED:
Tested the application before and after the changes, the screenshot below shows that the memory is not increasing with each batch run after the fix.
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master