Use typing.Annotation
for tagging (and remove autofill).
#344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
typing.Annotation
for tagging (and remove autofill).Until this change, there are 2 ways to tag a field in Fiddle: (1) using the
imperative
fiddle.set_tags
(andfriends)
API, and (2) the data-flow
MyTag.new(some_value)
approach. Both of thesework well, but it's convenient to have a more declarative API.
This change allows a library to tag fields in a dataclass or parameters to a
function using
typing.Annotated
. For example:Autofill first explored leveraging the
typing.Annotation
design. Thelessons learned from that are being incorporated into the next-generation
design of tagging.