Remove empty tag sets when flattening a buildable. #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_521022964
branch
2 times, most recently
from
9083843
to
dc911bb
Compare
While this is a trivial change from the perspective of what's being serialized, this is quite important due to the use of `__flatten__` powering the diffing infrastructure. In particular, if a config has tag added, and subsequently removed, it will now have an empty set associated with that argument. Before this change, the diffing tooling will find that this added-and-removed config is different than the one that never had the tag set in the first place. This is naturally extremely confusing and also a bug. PiperOrigin-RevId: 522189292
copybara-service
bot
force-pushed
the
test_521022964
branch
from
dc911bb
to
b565640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove empty tag sets when flattening a buildable.
While this is a trivial change from the perspective of what's being
serialized, this is quite important due to the use of
__flatten__poweringthe diffing infrastructure. In particular, if a config has tag added, and
subsequently removed, it will now have an empty set associated with that
argument. Before this change, the diffing tooling will find that this
added-and-removed config is different than the one that never had the tag
set in the first place. This is naturally extremely confusing and also a
bug.