[TS] Fix reserved words as arguments (#6955) #6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from google/flatbuffers
If a struct has a key the vector has to be sorted. To sort the vector you can't use "const".
* option indent_step is supported
github-actions
bot
added
c++
codegen
|
Thanks! As mentioned in #6955, can you extend the use of this function to other generated names? @krojew @bjornharrtell |
|
I think other generated names does not make any trouble. I have tested several hundreds of our flatbuffers schemas and reserved words are only not allowed as arguments in TS. Astonishingly these words can be used even as method names. So flatbuffers names like struct/table, enum values, ... did not lead to non working TS code. |
|
Ok, sounds like this will be sufficient for now then, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use same mechanism as in c# implementation for convenient code maintenance.
Fix is compatible for users of the generated .ts code.