Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE.txt to python #7692

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

rishabhdeepsingh
Copy link
Contributor

@rishabhdeepsingh rishabhdeepsingh commented Dec 4, 2022

This PR Fixes #7628
Added LICENSE file to python setup.py and for the next releases the LICENSE fill will be automatically added to the distribution wheel.

@github-actions github-actions bot added the python label Dec 4, 2022
@rishabhdeepsingh rishabhdeepsingh changed the title Add LICENSE.txt to python #7628 Add LICENSE.txt to python Dec 4, 2022
python/setup.py Outdated Show resolved Hide resolved
@rishabhdeepsingh
Copy link
Contributor Author

I have added the relative path and LICENSE.txt is now showing in the flatbuffers-XXX.dist-info
Can you please try at your end to see if this worked?

@dbaileychess dbaileychess merged commit a8d49f2 into google:master Dec 6, 2022
@dbaileychess
Copy link
Collaborator

I'll come back to this the next time I release, which should be in a day or so.

@rishabhdeepsingh
Copy link
Contributor Author

Thanks for the merge and review.

@rishabhdeepsingh rishabhdeepsingh deleted the python branch December 6, 2022 08:55
sunwen18 pushed a commit to sunwen18/flatbuffers that referenced this pull request Dec 25, 2022
* Add LICENSE.txt to python

* Remove LICENSE.txt from python path and used the root LICENSE.txt file
candhyan pushed a commit to mediaz/flatbuffers that referenced this pull request Jan 2, 2023
* Add LICENSE.txt to python

* Remove LICENSE.txt from python path and used the root LICENSE.txt file
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Add LICENSE.txt to python

* Remove LICENSE.txt from python path and used the root LICENSE.txt file
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Add LICENSE.txt to python

* Remove LICENSE.txt from python path and used the root LICENSE.txt file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flatbuffers 22.10.26 python distribution missing LICENSE.txt file
2 participants