Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS. #7729

Merged
merged 6 commits into from
Dec 22, 2022
Merged

Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS. #7729

merged 6 commits into from
Dec 22, 2022

Conversation

engedy
Copy link
Contributor

@engedy engedy commented Dec 21, 2022

Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS.

@github-actions github-actions bot added the CI Continuous Integration label Dec 21, 2022
@github-actions github-actions bot added the c++ label Dec 21, 2022
@engedy
Copy link
Contributor Author

engedy commented Dec 21, 2022

This is adding a new CI check to serve as a regression test to prevent regressions like the one fixed in #7728.

This PR should be rebased on top of #7728 before landing.

@engedy
Copy link
Contributor Author

engedy commented Dec 22, 2022

Derek, please take another look.

@dbaileychess dbaileychess merged commit 4e396d4 into google:master Dec 22, 2022
sunwen18 pushed a commit to sunwen18/flatbuffers that referenced this pull request Dec 25, 2022
@engedy @dbaileychess
Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS. (google#7729)
d8792cc 
* Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS

* Fix cmake syntax

* Further fix cmake argumetns

* Add workaround for unused-parameter.

* Remove build matrix

Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@engedy @dbaileychess
Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS. (google#7729)
e4c5dcc 
* Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS

* Fix cmake syntax

* Further fix cmake argumetns

* Add workaround for unused-parameter.

* Remove build matrix

Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@engedy @dbaileychess
Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS. (google#7729)
53a76d0 
* Add CI step to build with -DFLATBUFFERS_NO_FILE_TESTS

* Fix cmake syntax

* Further fix cmake argumetns

* Add workaround for unused-parameter.

* Remove build matrix

Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaileychess dbaileychess dbaileychess approved these changes

Assignees
No one assigned
Labels
c++ CI Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engedy @dbaileychess