Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operator==() generated for field of fixed sized array #7749

Merged
merged 6 commits into from
Jan 6, 2023
Merged

Fix operator==() generated for field of fixed sized array #7749

merged 6 commits into from
Jan 6, 2023

Conversation

enum-class
Copy link
Contributor

Fix issue #7746

@enum-class enum-class marked this pull request as draft January 1, 2023 04:04
@github-actions github-actions bot added c++ codegen Involving generating code from schema labels Jan 1, 2023
@enum-class enum-class marked this pull request as ready for review January 1, 2023 04:55
sunwen18
sunwen18 reviewed Jan 4, 2023
View reviewed changes
tests/test.cpp Outdated Show resolved Hide resolved
@enum-class enum-class requested review from sunwen18 and dbaileychess and removed request for sunwen18 and dbaileychess January 4, 2023 14:17
@dbaileychess dbaileychess merged commit 74b5195 into google:master Jan 6, 2023
@enum-class enum-class deleted the compare_array branch January 8, 2023 01:38
sunwen18 pushed a commit to sunwen18/flatbuffers that referenced this pull request Jan 9, 2023
@enum-class @dbaileychess
Fix operator==() generated for field of fixed sized array (google#7749)
8234346 
* Fix operator==() generated for field of fixed sized array

* Compare address

* noexcept

* Grammer

Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@enum-class @dbaileychess
Fix operator==() generated for field of fixed sized array (google#7749)
5e89991 
* Fix operator==() generated for field of fixed sized array

* Compare address

* noexcept

* Grammer

Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@enum-class @dbaileychess
Fix operator==() generated for field of fixed sized array (google#7749)
af708c3 
* Fix operator==() generated for field of fixed sized array

* Compare address

* noexcept

* Grammer

Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunwen18 sunwen18 sunwen18 left review comments

@dbaileychess dbaileychess Awaiting requested review from dbaileychess

Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enum-class @dbaileychess @sunwen18