Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configs for vae example #3254

Merged
merged 2 commits into from
Aug 11, 2023
Merged

feat: add configs for vae example #3254

merged 2 commits into from
Aug 11, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

@SauravMaheshkar SauravMaheshkar commented Aug 2, 2023

What does this PR do?

(partly) Fixes #573

Request for Review: @andsteing

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/discussion (Updating linen_examples/vae #573 (comment)).
  • The documentation and docstrings adhere to the documentation guidelines.
  • This change includes necessary high-coverage tests. (No quality testing = no merge!)

Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
examples/vae/train.py Outdated Show resolved Hide resolved
examples/vae/train.py Outdated Show resolved Hide resolved
examples/vae/main.py Outdated Show resolved Hide resolved
@levskaya
Copy link
Collaborator

levskaya commented Aug 9, 2023

@SauravMaheshkar - we use the pyink (google's black fork) autoformatter these days, could you run your changes through the formatter? https://github.com/google/pyink

Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
@SauravMaheshkar
Copy link
Contributor Author

@levskaya Addressed in db7b176

@copybara-service copybara-service bot merged commit d05aeab into google:main Aug 11, 2023
16 checks passed
@SauravMaheshkar SauravMaheshkar deleted the saurav/vae branch August 11, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating linen_examples/vae
2 participants