[nnx] jit constrain object state #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
nnx-jit-apply-sharding
branch
from
0cd5f38
to
1ee69d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3817 +/- ##
==========================================
+ Coverage 61.05% 61.25% +0.20%
==========================================
Files 105 105
Lines 13100 13167 +67
==========================================
+ Hits 7998 8066 +68
+ Misses 5102 5101 -1 ☔ View full report in Codecov by Sentry. |
cgarciae
force-pushed
the
nnx-jit-apply-sharding
branch
from
1ee69d6
to
a88fbbb
Compare
superbobry
reviewed
Apr 12, 2024
| donate_object_state: bool | ||
| constrain_object_state: tp.Callable[[State], State] | None |
There was a problem hiding this comment.
Please document what this field does either here or elsewhere.
superbobry
reviewed
Apr 12, 2024
| @@ -138,6 +138,11 @@ class JitStaticOutputs: | |||
|
|
|||
| jax.tree_util.register_static(JitStaticOutputs) | |||
|
|
|||
| def _default_constrain_object_state(state: State) -> State: | |||
| state_spec = spmd.get_partition_spec(state) | |||
| state = jax.lax.with_sharding_constraint(state, state_spec) | |||
There was a problem hiding this comment.
Is WSC a noop if there is no mesh?
There was a problem hiding this comment.
Nope, it will crash.
superbobry
approved these changes
Apr 12, 2024
cgarciae
force-pushed
the
nnx-jit-apply-sharding
branch
from
a88fbbb
to
91ee438
Compare
cgarciae
force-pushed
the
nnx-jit-apply-sharding
branch
from
91ee438
to
8192b96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
constrain_object_stateargument tonnx.jitwhich can be either aCallable[[State], State](a function creating the new constrained State, or abool. WhenTruetheStatewill be constrained usingnnx.get_partition_specpassed tojax.lax.with_sharding_constraint.