-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter/plugins] Support url_launcher #224
Comments
Definitely a good plugin to support. This will be the first instance of adding only the desktop platform side of a plugin, with the Dart side coming from another repository, but I expect that there will be other common Flutter plugins that we'll want to do that with, so we'll need to figure out a good pattern for handling that (especially documenting what using them would look like). |
Will a discussion be taken here about how to handle that aspect of plugin "extension" to desktop? if so my questions are:
|
I can't speak for the Flutter project as to their future plans. The scope of the discussion here is building out desktop support for
I'm not sure I understand the question; platform-side implementations for desktop platforms need to interoperate with the existing Dart code, or re-using the Dart side wouldn't work. Other than that I'm not sure what compatibility you have in mind. Bear in mind that the goal here isn't to solve the much larger problem of creating a mobile-Flutter-plugin-like federated distribution system, with automated fetching and building. The implementation here will be within the existing structure of client projects manually pulling in plugin implementations. |
Yes. We're trying to plan out how to do this now. (My recommendation would be to put the support in the plugin itself, not split into another repo. And as part of doing that, figure out how it should all work. :-) ) |
Ok I was thinking at a different problem. I wanted to try to make it as painless as possible to take a current flutter app and provide indications to the embedder on where to find the platform implementation for its dependencies. This would be quite far from @Hixie 's recommendation and with hindsight it does seems like a "waste" of time once the majority of packages do provide said implementation. |
There have been many changes since the discussion above, especially with respect to:
which is well underway. However, it'll be a while before Linux and Windows have stable plugin APIs and #433 will do this for |
Sets up a new structure and README for landing implementations of plugins from the flutter/plugins repository before they are ready to be officially hosted (e.g., while plugin APIs stabilize). Using that structure, adds an initial implementation of url_launcher for macOS and Linux as a proof of concept. Fixes #224 (except for Windows, for which we have #105)
It would be great if we could add support for this plugin:
https://github.com/flutter/plugins/tree/master/packages/url_launcher
Thanks!
The text was updated successfully, but these errors were encountered: