Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter/plugins] Support url_launcher #224

Closed
shyndman opened this issue Jan 10, 2019 · 6 comments · Fixed by #433
Closed

[flutter/plugins] Support url_launcher #224

shyndman opened this issue Jan 10, 2019 · 6 comments · Fixed by #433

Comments

@shyndman
Copy link

It would be great if we could add support for this plugin:
https://github.com/flutter/plugins/tree/master/packages/url_launcher

Thanks!

@stuartmorgan
Copy link
Collaborator

Definitely a good plugin to support.

This will be the first instance of adding only the desktop platform side of a plugin, with the Dart side coming from another repository, but I expect that there will be other common Flutter plugins that we'll want to do that with, so we'll need to figure out a good pattern for handling that (especially documenting what using them would look like).

@GregorySech
Copy link

Will a discussion be taken here about how to handle that aspect of plugin "extension" to desktop?

if so my questions are:

  • will the desktop embedding be integrated in the future into the current flutter/flutter repo/tooling?
  • how important is compatibility with the current flutter mobile app projects for the "extended" plugins?

@stuartmorgan
Copy link
Collaborator

will the desktop embedding be integrated in the future into the current flutter/flutter repo/tooling?

I can't speak for the Flutter project as to their future plans. The scope of the discussion here is building out desktop support for url_launcher within the existing project structure.

how important is compatibility with the current flutter mobile app projects for the "extended" plugins?

I'm not sure I understand the question; platform-side implementations for desktop platforms need to interoperate with the existing Dart code, or re-using the Dart side wouldn't work. Other than that I'm not sure what compatibility you have in mind.

Bear in mind that the goal here isn't to solve the much larger problem of creating a mobile-Flutter-plugin-like federated distribution system, with automated fetching and building. The implementation here will be within the existing structure of client projects manually pulling in plugin implementations.

@Hixie
Copy link

Hixie commented Jan 10, 2019

will the desktop embedding be integrated in the future into the current flutter/flutter repo/tooling?

Yes. We're trying to plan out how to do this now.

(My recommendation would be to put the support in the plugin itself, not split into another repo. And as part of doing that, figure out how it should all work. :-) )

@GregorySech
Copy link

Ok I was thinking at a different problem.

I wanted to try to make it as painless as possible to take a current flutter app and provide indications to the embedder on where to find the platform implementation for its dependencies.

This would be quite far from @Hixie 's recommendation and with hindsight it does seems like a "waste" of time once the majority of packages do provide said implementation.

@stuartmorgan stuartmorgan changed the title Add the url_launcher plugin [flutter/plugins] Support url_launcher Jun 12, 2019
@stuartmorgan
Copy link
Collaborator

There have been many changes since the discussion above, especially with respect to:

(My recommendation would be to put the support in the plugin itself, not split into another repo. And as part of doing that, figure out how it should all work. :-) )

which is well underway.

However, it'll be a while before Linux and Windows have stable plugin APIs and flutter tooling support for plugins, so I've decided to temporary host implementations of some flutter/plugins desktop implementations here for now, all of which will migrate to official hosting as the APIs and tooling support is ready for them. That will allow people to experiment with desktop applications using those plugins earlier, without pushing the maintenance burden of unstable APIs onto another repo. (At this point this repo already has an interim structure+documentation for using plugins here, so doing so is straightforward.)

#433 will do this for url_launcher (with at least a couple of other simple plugins to follow).

stuartmorgan added a commit that referenced this issue Jun 17, 2019
Sets up a new structure and README for landing implementations of
plugins from the flutter/plugins repository before they are ready to
be officially hosted (e.g., while plugin APIs stabilize).

Using that structure, adds an initial implementation of url_launcher
for macOS and Linux as a proof of concept.

Fixes #224 (except for Windows, for which we have #105)
@google google locked and limited conversation to collaborators Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants