[WIP] FFI Implementation #7
Conversation
packages/mediapipe-core/README.md
Outdated
| [developing packages and plugins](https://flutter.dev/developing-packages). | ||
| --> | ||
|
|
||
| TODO: Put a short description of the package here that helps potential users |
There was a problem hiding this comment.
Just a note to self to come back and review this when it;s filled out. :)
| 'You must supply either `modelAssetBuffer` or `modelAssetPath`', | ||
| ), | ||
| assert( | ||
| !(modelAssetBuffer != null && modelAssetPath != null), |
There was a problem hiding this comment.
And this ensures both are not provided.
Might be worth unpacking both into a single assertion with a function body so you could use control flow for better readability and error messaging.
| } | ||
|
|
||
| class ClassifierOptions extends Equatable { | ||
| const ClassifierOptions({ |
There was a problem hiding this comment.
Are there requirements that any of these values are set? What happens if they all are null?
packages/mediapipe-core/pubspec.yaml
Outdated
| description: A starting point for Dart libraries or applications. | ||
| version: 1.0.0 | ||
|
|
||
| repository: https://github.com/google/flutter-mediapipe |
There was a problem hiding this comment.
Is there an issue tracker? In flutter/packages we usually include an issue_tracker
|
|
||
| analyzer: | ||
| exclude: | ||
| - "lib/src/mediapipe_common_bindings.dart" |
There was a problem hiding this comment.
It's generated code, so occasionally it will fall behind our latest best practices in flutter_lint and cause IDE analysis server noise.
|
|
||
| analyzer: | ||
| exclude: | ||
| - "lib/src/mediapipe_text_bindings.dart" |
There was a problem hiding this comment.
Same "its generated code" answer :)
| // AUTO GENERATED FILE, DO NOT EDIT. | ||
| // | ||
| // Generated by `package:ffigen`. | ||
| // ignore_for_file: type=lint |
There was a problem hiding this comment.
Is this necessary if it is excluded in the analysis options?
| // Generated by `package:ffigen`. | ||
| // ignore_for_file: type=lint | ||
| import 'dart:ffi' as ffi; | ||
| import 'package:mediapipe_core/src/mediapipe_common_bindings.dart' as imp1; |
There was a problem hiding this comment.
I believe it's "implementation one", but this is generated code.
|
|
||
| typedef TextClassifierResult = imp1.ClassificationResult; | ||
|
|
||
| const int true1 = 1; |
There was a problem hiding this comment.
What are these super fun values? Maybe I am missing context
There was a problem hiding this comment.
I think the context is that C is bad at booleans 😆
craiglabenz
force-pushed
the
ffi-wrapper
branch
from
e2d9cbd
to
3046f3e
Compare
Summary
Adds a MediaPipe implementation that talks directly to C++ via FFI. (Technically, indirectly and through a C intermediary, but still fairly directly in comparison to method channels.)
C bridge code uses Dart's native FFI functionality and
ffigento automatically generate the required bindings from C headers pulled from the MediaPipe repository.TODOs
mediapipe_corepackage (Adds mediapipe_core package #11)mediapipe_textpackage (Adds mediapipe_text package #12)native-assetsto vendor MediaPipe SDK #9)mediapipe_visionpackage (Adds mediapipe_vision package #13)TESTING
To run this PR locally, complete the following steps (on macOS):
google/mediapipewith the latest internal changes pulled down, run this build command:libtext_classifier.dylibfile (found in thebazel-outdirectory) to this repository at thepackages/mediapipe-task-text/examples/assetsdirectory.Download
bert_classifier.tfliteand place it in the same directory.Run the example app and click the floating action button to classify text.