Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low double quotation mark (99) is missing #129

Closed
kilograd opened this issue Sep 30, 2015 · 3 comments
Closed

Low double quotation mark (99) is missing #129

kilograd opened this issue Sep 30, 2015 · 3 comments
Assignees
@graphicore

Comments

@kilograd
Copy link

Hi,
in all Poppins font styles I am missing the 99 low quotation mark. This is necessary for german quotation. ,,quotation´´ is the style. Basically it is just a double comma. Will sometime be there an update?
Best, Peter
@davelab6 davelab6 modified the milestone: Bugs Jul 25, 2016
@graphicore graphicore self-assigned this Aug 29, 2016
graphicore added a commit to graphicore/poppins that referenced this issue Aug 30, 2016
@graphicore
quotedblbase shows both quote signs google/fonts#129
84990c2 
Apparently, quotedblbase consisted already of two comma components but
they were on the same spot.

NOTE: I replaced the comma components in quotedblbase and in quotesinglbase
with components of quoteright, because the bold comma is heavier than the
bild quoteright and that caused an imbalance between the base-line quotes
and the upper quotes.
graphicore added a commit to graphicore/poppins that referenced this issue Aug 30, 2016
@graphicore
quotedblbase shows both quote signs google/fonts#129
d5d4875 
Apparently, quotedblbase consisted already of two comma components but
they were on the same spot.

NOTE: I replaced the comma components in quotedblbase and in quotesinglbase
with components of quoteright, because the bold comma is heavier than the
bold quoteright and that caused an imbalance between the base-line quotes
and the upper quotes.
@graphicore
Copy link
Collaborator

PR: itfoundry/Poppins#6

This is happens when Glyphs auto generates the quotedblright glyph. I'll write a small script to check for this and simmilar errors and add it to @m4rc1e mf-glyphs-scripts

m4rc1e referenced this issue in m4rc1e/fonts Jul 25, 2017
@m4rc1e
poppins: v2.200 added.
ee982fc 
Fixes, google#564, #404, #403, #351, #129
@m4rc1e m4rc1e mentioned this issue Jul 25, 2017
Merged
@m4rc1e
Copy link
Collaborator

m4rc1e commented Jul 25, 2017

Fixed in #1099

screen shot 2017-07-25 at 11 57 43

Leaving open until family makes it into production

davelab6 pushed a commit that referenced this issue Jul 26, 2017
@m4rc1e @davelab6
poppins: v2.200 added. (#1099)
e3676e5 
Fixes, #564, #404, #403, #351, #129
@laerm0
Copy link
Contributor

laerm0 commented Sep 11, 2017

This is fixed now so I am closing.

screen region 2017-09-11 at 14 40 19

@laerm0 laerm0 closed this as completed Sep 11, 2017
emmamarichal pushed a commit that referenced this issue Jan 4, 2024
@moyogo
Merge pull request #129 from googlefonts/hira-exemplars
5e7e432 
Add hiragana exemplars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graphicore graphicore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@davelab6 @graphicore @m4rc1e @laerm0 @kilograd