-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari 12 crashes upon clicking a <select> element that uses Quicksand #2155
Comments
Thanks for reporting! can confirm your findings. I'll investigate further. |
I know a font engineer at Apple so I will get them to take a look. In the meantime, I'll keep debugging the source. |
Apple employee can't replicate the issue on OS X 10.15 (Catalina, still not released) but we can in 10.14. I'll investigate further this week and submit a fix if I can find the issue. |
I was able to recreate the issue and get it working. It seems to be directly related to how the font is loaded. The following fails:
But this works (for some reason):
Took me forever to realize this is what was crashing my app. |
The issue happened to me also. The simple solution is you can remove the "font-family: 'Quicksand', sans-serif;" from the body in CSS and call it separately in h1, h2, p....etc.. I have added the below in my CSS file: and removed "font-family: 'Quicksand', sans-serif;" from body in CSS. |
I found this exact same issue for the Muli font. |
@m4rc1e your jsfiddle works for me. Check out this page on safari. https://tornadoughalli.com -- this crashes for me and the user. For some others, it does not. If I inspect the elements and delete the following element AFTER the page renders, everything works hunkey dory: Safari Version 12.1.1 (14607.2.6.1.1) |
Also, I change the font and it works fine. |
@bemyhre your embed doesn't look correct. If I pick Open Sans + Roboto Condensed with a variety of weights and I only want Cyrillic + Vietnamese, I get the following embed which appears much cleaner.
Please don't make a custom embed, just use the font selector on fonts.google.com. It will build it for you. |
Also experiencing this in Safari 12 with Dosis, Muli, and Rokkit. This Codepen crashes for me consistently: |
Thanks for the test case @nickendle. Are you running OS X 10.14? I'm not able to replicate the issue on 10.15. |
@m4rc1e sure thing! This is crashing with OSX 10.14, all later versions of Safari/OSX seem to work ok. |
Thanks for confirming. I'll see if we're making any unnecessary modifications to the fonts which may be causing this. |
Just tried the codepen on 10.13 and can confirm it crashed Safari. |
@m4rc1e thanks for checking this out - just wondering if any progress has been made on finding out the cause? |
Seems as though this issue has been fixed! I'm not experiencing any crashing with the same tests I tried before.. but I'm curious to see if others in this thread are seeing the same thing. |
Yeah, it magically seems to be working for me as well. I hadn't even realized it until I noticed one of my sites loading the CSS as:
and not the multiple call as I previously had as the workaround. And I was like...Oh...it's fixed?! 😝 |
Is it the font or Safari (or Mac OS) that has been fixed? It'd be nice to know if font-family can safely be applied to elements. |
A page will crash in MacOS Safari 12 at the moment the user clicks a select element whose font-family is Quicksand.
A reduced test case is below (or visit https://jsfiddle.net/nL1abgwx)
Notes:
border: 0
because Safari will not apply the font without it (see here: https://css-tricks.com/dropdown-default-styling/#article-header-id-2)The text was updated successfully, but these errors were encountered: